rncbc / qtractor

Qtractor - An Audio/MIDI multi-track sequencer
https://qtractor.org
GNU General Public License v2.0
495 stars 86 forks source link

Insert Send display issue (and maybe more) #445

Open suedwestlicht opened 2 months ago

suedwestlicht commented 2 months ago

I had some problems with an existing session when inserting an Insert Send into the Master Audio Bus. It worked fine, but after saving/loading the session the Insert Sends were renumbered and there were some MIDI tracks' audio bus displayed as before (e.g. "Drums") but the output went to another bus 1 position left ("e.g. Common").

I tried the whole afternoon creating a minimal session where this occurs but I failed. I noticed that type= and name= were swapped after inserting or deleting an Insert Send:

before: track type="midi" name="Pad 1" after: track name="Pad 1" type="midi"

That should not make any difference when Qtractore loads and parses the file so I looked for another glitch that might lurk in Qtractor and I found at least a display issue. If there are more than 9 Insert Sends in a Qtractor session then the Insert Send 1 "Send" window shows other Insert Sends > 9 as well.

Maybe it's only a display problem but there might be a chance that this affects loading/parsing a session file as well.

Bildschirmfoto_2024-05-05_18-08-32

rncbc commented 2 months ago

the later is just a display issue, will get fixed soon, thanks

EDIT: fixed in 623bd357

suedwestlicht commented 1 month ago

Confirmed. Thx.

suedwestlicht commented 1 month ago

Now I got more. I could create a sample session that reveals the Insert Send bug.

It's a simple session with one MIDI track (Yoshimi) and 3 Output Buses sum1, sum2, sum3. All Output Buses go to the Master Bus. All Output Buses have an Insert Send (to itself to make it simple). The MIDI track goes to Output Bus sum2.

That works ok.

Now add an Insert Send (e.g. to itself) in the Master Bus. That becomes "Insert 4".

That still works ok.

Now save this session and reload it. The Inserts are renumbered. That may be ok and intended.

But:

masterinserttest.qtz.zip

rncbc commented 1 month ago

maybe fixed in https://github.com/rncbc/qtractor/commit/377c485534a0070980d69e2966df64adf90c7870

please test && tell

nb. you'll have to save it first once to reload in correct order again.

suedwestlicht commented 1 month ago

Yes, it's fixed. Thx Rui.