search

rncbc / qtractor

Qtractor - An Audio/MIDI multi-track sequencer
https://qtractor.org
GNU General Public License v2.0
514 stars 90 forks source link

Provide `bar_start_tick` in JACK BBT information #475

Closed theGreatWhiteShark closed 1 month ago

theGreatWhiteShark commented 2 months ago

qtractor does not set the bar_start_tick field in the BBT part of the JACK transport position.

Occasionally, (e.g. hydrogen as client relocates transport while playback is rolling with qtractor in control of JACK Timebase) this field will be filled with nan. If not prepared for it, this can really mess up transport calculation of clients internally.

If for some reason the ticks passed till the onset of the current bar is infeasible to calculate, you could maybe fill the field with -1. But nan is nasty.

rncbc commented 2 months ago

also done in c07595b

thanks

theGreatWhiteShark commented 1 month ago

Thanks!

also done in https://github.com/rncbc/qtractor/commit/c07595b6cbc561ad4aceb6f5a262a388a9076742

I left some comments in there

theGreatWhiteShark commented 1 month ago

Work's fine. Thanks!