search

rncbc / rtirq

rtirq - Startup script for realtime-preempt enabled kernels
GNU General Public License v2.0
40 stars 6 forks source link

Pattern matching error #14

Open capocasa opened 5 months ago

capocasa commented 5 months ago

I had a bit of an issue with my wifi getting prioritized instead of my sound card.

This line:

PIDS=`ps -eo pid,comm | grep -Ei "irq.${IRQ}" | awk '{print $1}'`

within rtirq_get_pids is the fallback if no other irq threads get found.

Now the issue is this matches lines like this one:

397 irq/162-iwlwifi:queue_6

Where iwlwifi is the wireless driver.

I believe it could be fixed by adding a [^0-9] after ${IRQ} to avoid partially matching numbers but there may be a more elegant way.

rncbc commented 5 months ago

you may raise a PR for just that, thanks

capocasa commented 5 months ago

Can't test so well right because of other parts of my xrun quest but I'll see what I can do!

It would probably also help to discover potential similar issues to derive the name from actual interrupt thread from output in order to confirm what as been done as opposed to what was attempted.