rnd-ash / OpenVehicleDiag

A rust based cross-platform ECU diagnostics and car hacking application, utilizing the passthru protocol
GNU General Public License v3.0
773 stars 90 forks source link

OVD doesn't with ValueCAN4-2 #48

Open nico0481 opened 2 years ago

nico0481 commented 2 years ago

Hello,

I'm trying to use OVD with ValueCAN4-2. Interface is correctly recognized with the pick list but when I try to do: Diagn Scanner-->Scan my car-->Start scan, I get the answer: "could not start scanning: Battery voltage too low/ Could not read battery voltage.

There is no power supply connection on ValueCAN4 DB9 pinout, only CAN1 H/L, CAN2 H/L and 3 GND.

Regards

bondango commented 2 years ago

The battery voltage is a can value from your vehicle not from your hardware. So i would ensure all connections are correct but

app_rust/src/windows/diag_scanner.rs

L71-76 is the battery check function - by pass it

fn increment_stage(&mut self) -> Option<DiagScannerMessage> {
    match self.curr_stage {
        0 => {
            if self.adapter.read_battery_voltage().unwrap_or(0.0) < 11.7 {
                self.status = "Battery voltage too low / Could not read battery voltage".into();
                return None;