search

rnd-ash / razer-laptop-control

Project to create driver/software to control performance of razer laptops
GNU General Public License v2.0
345 stars 29 forks source link

kernel coding style should be followed #10

Closed gregkh closed 4 years ago

gregkh commented 4 years ago

As this is a Linux kernel driver, the proper coding style rules should be followed.

You can run scripts/checkpatch.pl with "--file" added to it to find the problems that need to be resolved, or I can submit a patch that does this as well (but it would touch almost every line of the driver files, and that's a bit rude of me to do without asking :)

rnd-ash commented 4 years ago

either way, I don't mind...

Being a second year student who's self taught himself C in about 3 months, my code is inherently going to be bad so I appreciate being pointed to help write better code :).

I'd say then if you want to, submit a patch please.

gregkh commented 4 years ago

Thanks. All should now be almost fixed up with pull request #11

rnd-ash commented 4 years ago

Thanks a lot! :)...merged your PR