Lookup map reverse lookup functionality

rnd-ash / ultimate-nag52-fw

Ultimate NAG52 firmware repository

GNU General Public License v3.0

46 stars 21 forks source link

Lookup map reverse lookup functionality #64

Closed rnd-ash closed 8 months ago

chrissivo commented 9 months ago

Hi @rnd-ash , I've added some functionality for the Hfm-CAN and would need to merge it to dev. Do you have any concerns?

rnd-ash commented 9 months ago

@chrissivo i tried to merge the PR, and noticed a couple issues.

Firstly, parking_lock_teeth count in the configuration (EEPROM_CONFIG.H) is already defined in code as input_sensor_pulses_per_rev. So I don't think we need this extra configuration option.

Secondly, please remove the files in your .vscode folder from the PR

chrissivo commented 9 months ago

Hi @rnd-ash , Thank you for the hints. Have removed the unneccessary parameter parking_lock_teeth and the respective files as well.

rnd-ash commented 8 months ago

Merged finally! Thank you @chrissivo for working on this, ill mention it in the changelog