search

rnd-ash / ultimate-nag52-fw

Ultimate NAG52 firmware repository
GNU General Public License v3.0
49 stars 23 forks source link

Improve auto drive logic #7

Open rnd-ash opened 2 years ago

rnd-ash commented 2 years ago

Currently, all 3 automatic profiles (C/S/A) all use the same algorithm for calculating auto shift points.

  1. Take engine RPM tachometer as a dial from 0-100%
  2. Take pedal position as a percentage from 0-100%

If pedal percentage is more than 2x that of engine RPM percentage, then downshift If engine RPM is greater than pedal position, upshift

This is super undesirable as it creates a lot of random up/down shifting

viper-666 commented 1 year ago

I think it should up/downshift with fixed points who are different by profile (C/S/A). There have to be three shift points

  1. min rpm (before shifting down)
  2. should be rpm (what is the goal to reach when cruising)
  3. max rpm (at what it upshifts). I mean something like that in comfort shift up if rpm is greater than 3000rpm or shift up earlier when the driver don't accelerate and is above "should be" rpm (+/- maybe 100rpm).