search

rndme / download

file downloading using client-side javascript
MIT License
2.29k stars 417 forks source link

Update download.js #25

Closed glittle closed 8 years ago

glittle commented 8 years ago

My screen flickers slightly when the download function is run. That is because I have no scrollbars, but when the a tag is added, scrollbars are added. This addition eliminates the problem.

rndme commented 8 years ago

thanks for the pr. i'll have to run some tests because i thought some browsers try to guard against the programmatic clicking of completely invisible links, and one asset of download.js is its extensive legacy browser support. based on recent feedback, i have a few other updates to make to the codebase as well. i'll try to make yours first if it tests out ok so you get the cred, but if it needs a logic branch to prevent triggering a certain browser's bad activity list or to allow A.T. interaction, i might ask you to resubmit a new pull after non-related refactoring. in the mean time, there is a CSS class on the link that you can use to hide it for your site, .download-js-link{display:none} thanks for the idea, and expect hear back from me.