search

rndusr / stig

TUI and CLI for the BitTorrent client Transmission
GNU General Public License v3.0
556 stars 24 forks source link

Fix disk space widget bug #160

Closed lenormf closed 4 years ago

lenormf commented 4 years ago

Follow-up to #157.

https://github.com/rndusr/stig/pull/157#issuecomment-633228205

rndusr commented 4 years ago

Oh, I'm sorry, I thought I was going to fix this. I guess I should've been more clear.

I also realized that your implementation polls more than necessary from the daemon. I limited that by making FreeSpaceAPI listening to SettingsAPI updates so it can get the paths from the cache instead of one additional request per path.

I've also split FreeSpaceAPI into a base class and a very simple Transmission-specific derivative. That will make it easier to add support for other BitTorrent clients.

I'm sorry you wasted your time, but I'll have to decline. :(

lenormf commented 4 years ago

Alright, no problem.