search

rndusr / torf

Python module to create, parse and edit torrent files and magnet links
GNU General Public License v3.0
180 stars 17 forks source link

Add link to torf-gui in readme #32

Closed SavageCore closed 1 year ago

SavageCore commented 1 year ago

Hey

I decided to port dottorrent-gui to torf

https://github.com/SavageCore/torf-gui

Do you want to add this to the readme?

rndusr commented 1 year ago

Thank you for your effort, but this doesn't seem quite ready yet.

The installation fails: "No such file or directory: 'README.rst'". You renamed README.rst to README.md, but didn't notify setup.py about it.

https://github.com/SavageCore/torf-gui/blob/main/torfGUI/gui.py#L113 torf doesn't have an exceptions module and no EmptyInputException. (I'm surprised this doesn't immediately raise an exception.)

Dependencies are really outdated. Python 3.6 has been EOL (no security patches) since 2022: https://devguide.python.org/versions/#versions PyQT5 5.7 is from 2016!

The screenshots look weird. Like some columns of pixels were removed to reduce their width?

Sorry, but I don't want to endorse this in its current state. It really does look quick and dirty and not like something I would recommend to anyone.

SavageCore commented 1 year ago

Thanks for the feedback, I will get those issues sorted out!

Did you install it from pip or source?

Yeah, screenshots I will have to try and retake on another device, that's just how it looks on my new monitor.. I'm using MacType to try to better the clarity and some stuff renders like that.

rndusr commented 1 year ago

I installed with these commands in the cloned directory:

python3 -m venv test-venv
venv-activate test-venv
pip install --editable '.'

I always do a test install before a new release.

I would also recommend writing some tests with pytest and setting up tox with pyenv. Then you can just run tox and it runs all tests for each supported python version.

SavageCore commented 1 year ago

Done those changes, Mac renders the app much nicer, on the same screen. Damn Windows.

Will get some tests going soon.

rndusr commented 1 year ago

Looking much better now!

I've added the link now.

Another issue: Under "Torrent options", I think you mix up the number of pieces and piece size in bytes. Try selecting a small-ish file and select 16 MiB and it says "16777216 pieces @ 1 byte each".