rndusr / torf

Python module to create, parse and edit torrent files and magnet links
GNU General Public License v3.0
176 stars 17 forks source link

Drop non critical metainfo instead of erroring? #41

Open Ravencentric opened 5 months ago

Ravencentric commented 5 months ago

I recently encountered this torrent file in the wild and it has one invalid tracker url out of many.

Trying to read it raises a metainfo error

Traceback (most recent call last):
  File "C:\Users\raven\Documents\GitHub\TEST\test.py", line 10, in <module>
    torrent = Torrent.read_stream(BytesIO(open(path, "rb").read()))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Users\raven\Documents\GitHub\TEST\.venv\Lib\site-packages\torf\_torrent.py", line 1632, in read_stream
    torrent.validate()
  File "c:\Users\raven\Documents\GitHub\TEST\.venv\Lib\site-packages\torf\_torrent.py", line 1388, in validate
    utils.assert_type(md, ('announce-list', i, j), (str,), check=utils.is_url)
  File "c:\Users\raven\Documents\GitHub\TEST\.venv\Lib\site-packages\torf\_utils.py", line 727, in assert_type
    raise error.MetainfoError(f"{keychain_str}[{key!r}] is invalid: {obj[key]!r}")
torf._errors.MetainfoError: Invalid metainfo: ['announce-list'][4][0] is invalid: '*udp://9.rarbg.to:2710/announce'

I understand this is an invalid URL but is it possible to drop invalid metainfo instead of erroring? especially non critical ones like this where there are several more working trackers. This is a perfectly downloadable torrent and clients like Qbit simply report it as unsupported while continuing to download it

image

Possibly a strict: bool = True flag in read() and read_stream() where:

Thank you

Ravencentric commented 5 months ago

Using https://torf.readthedocs.io/en/latest/#torf.Torrent.validate is an option but it's not exactly the same. validate=False will no longer error but it'll still end up with an invalid torrent file while my proposal basically means torf will attempt to get a valid file out of a invalid one by dropping non critical invalid data. Torf should raise an error if the torrent file is still invalid after dropping as many non critical data as it could

I've also noticed that despite validate=False, property access still errors:

from torf import Torrent

path = r"C:\Users\raven\Downloads\[New-raws] Bucchigiri - 12 END [1080p] [AMZN].mkv.torrent"

torrent = Torrent.read(path, validate=False)

print(torrent.trackers) # Errors
print(torrent.infohash) # Errors
rndusr commented 5 months ago

I agree that this should be possible, but I don't see a straightforward way to implement it. torf is probably too overengineered by now. I'm afraid implementing it will break something else.