Review (Feb 17)

[dshgna]

Great work so far Neha!

home.html It's better to use JQuery's $(document).ready() instead of JS onload(). document.ready() is fired as soon as possible while onload() is called after all the page's content are loaded. More here.

fetchProblems() Here, we have to iterate through an array of objects. In JS, for...in is meant to be used to iterate over properties of objects. To iterate over an array, it is best to use either the sequential for loop or the newly introduced for...of loop can be used. More on this here

Displaying problem data from JSON file

1. Combine the problem.js files into a single JSON file. Using a JSON generator will make life easier ;)
2. For each object, include an "id" key.
3. JSON -> JS object conversion (http://api.jquery.com/jquery.getjson/)
4. Modify loadPage() to display the relevant problem for a particular page based on id.

Fix indentation - use Codepen's Tidy to get this done quickly

[rneha725]

• [x] I have used $(document).ready(...) in index.html (formerly home.html), also in other files wherever needed.
• [x] I tried to use for.. of but it showed error. So for array convention I used for(i=0;i<limits;i++)
• [ ] I have combined all problem data into problemList.js but the work of making it JSONis not - done.
• [x] I have used a problemCode in the place of id, please comment whether I need to add an id.
• [x] Instead of loadpage(), there is a problemTemplatePage.html,when it is loaded function loadProblemData() in loadProblems.js is invoked to fill up the template page.
• [x] Another commit needed for indentation.

[dshgna]

Really loving how you are taking the initiative!

1. Ideally, only external JS should be included in HTML. $(document).ready(...) should be in the JS. For example:

$(document).ready(function() {
navigationBar();
});

Having $(document).ready(...) in both the js files included is not a problem.

1. for...of may not be supported by your browser as its a recent construct, So a sequential for loop is perfectly fine here.
2. Using a problemCodealso works perfectly.
3. At the moment, you will need to have separate pages for the mock problems for testing, However, once we move into using React, the template will suffice.