search

rnelson0 / puppet-domain_join

Provides just enough configuration to join a Linux node to an Active Directory domain.
Apache License 2.0
1 stars 4 forks source link

Autojoin #25

Closed rnelson0 closed 7 years ago

rnelson0 commented 7 years ago

This completes @brettswift's efforts to automatically join the specified domain in a single run. It still needs some cleanup, but I'm opening this for review and CI tests to begin.

rnelson0 commented 7 years ago

@brettswift I know you aren't as close to this as you were before, so you may not be able to test it, but could you review the changes and see if I made any obvious mistakes? Thanks!

brettswift commented 7 years ago

Hey Rob, great to see this. Hopefully it's helping the RH7 end as well.

I had a peek but haven't tested it. I can't pick out anything obvious to comment on here. Looks good!

There might still be interest in getting this deployed here - I had left my feature branch on our control repo as is. So who knows, maybe it might get through our release process still.