search

rnelson0 / puppet-domain_join

Provides just enough configuration to join a Linux node to an Active Directory domain.
Apache License 2.0
1 stars 4 forks source link

Feature/rhel6-rhel7 compatibility #31

Closed chichimedina closed 7 years ago

chichimedina commented 7 years ago

Hello Rob,

 I'm working with `brettswift` who is another collaborator on this module.

 I found an issue when it comes to what packages need to be installed when the target system is RHEL6 or RHEL7. RHEL7 requires 'samba-common-tools' package but the same isn't available for RHEL6. Moreover, the content of 'samba-common-tools' is included in other RHEL6's packages. I solved it by adding a couple of 'if' statements.

There're multiple ways to program it but I followed this: keep a list of the common packages and add 'samba-common-tools' when the target server is RHEL7.

Second change is add two more packages regardless RHEL version for troubleshooting and to get extra utilities:

-- sssd-tools: to get tools such as 'sssctl' which allows to get the active domain controller name, get AD controllers latest status, cached users/groups and their expiration dates, etc etc. Another interested tool in this package is 'sss-seed' that lets you create users in sssd cache in the event a server gets offlline meaning these cached users can still log in though the server has no connection to AD (i.e. due to AD outage)

-- ldb-tools: it manipulates LDB files such as sssd cache file. You can query sssd cache for advanced user and group data retrieval.

These two packages are more for troubleshooting purposes and are widely available in RHEL6/RHEL7 repositories.

Thanks and happy to contribute!

rnelson0 commented 7 years ago

Awesome, @chichimedina! This seems like a simple enough change, just needs the lint fixes to paste the tests and I can merge it. Thanks!

rnelson0 commented 7 years ago

The tests need fixing, too!

brettswift commented 7 years ago

I'll be able to spend some time with @chichimedina tomorrow to get this test resolved. We'll squash all the commits into one for you as well.

rnelson0 commented 7 years ago

Thanks! Sorry, github doesn't notify on new commits, didn't notice it quickly.