search

rnelson0 / puppet-generate-puppetfile

Generate or update a Puppetfile for use with r10k or librarian-puppet. Optionally, create a fixtures file for rspec-puppet.
92 stars 22 forks source link

Changed style #2

Closed TomyLobo closed 8 years ago

rnelson0 commented 8 years ago

@TomyLobo Thanks for this patch! This needs two fixes before I can merge it, though, when you have the time.

rnelson0 commented 8 years ago

@TomyLobo I merged in two other changes from the bugs you pointed out, you'll need to rebase and resolve a conflict on the 1 vs \1 portion.

rnelson0 commented 8 years ago

@TomyLobo I figured out how to correct the merge conflict and update the branch, so I merged it. The subtle bugs you uncovered are pretty important so I wanted to get it patched. Thanks so much for the work!

TomyLobo commented 8 years ago

Looks like you got all my changes in.

About the color code fix you added: Shouldn't puppet detect stdout not being a terminal and automatically turn off colors?