search

rnelson0 / puppet-generate-puppetfile

Generate or update a Puppetfile for use with r10k or librarian-puppet. Optionally, create a fixtures file for rspec-puppet.
92 stars 22 forks source link

Add support for updating from git #25

Closed jyaworski closed 6 years ago

jyaworski commented 8 years ago

Currently, this module only works with the forge versions of modules. Can this also have git functionality? For example, if I want to update all of my modules to the latest HEAD.

Example:

mod 'archive',
        :git    => 'https://github.com/voxpupuli/puppet-archive.git',
        :commit => 'f382f2d199574590739394050302f626056ad15e'

mod 'auditd',
        :git    => 'https://github.com/kemra102/puppet-auditd.git',
        :commit => '9958c76401085e96bf1b70bc059770b93c2585a0'
joseph.yaworski@jyaworski-mbpr ~ % git ls-remote https://github.com/voxpupuli/puppet-archive.git HEAD
24eace7915d1f08148a040d474cf4b2f72558779    HEAD

joseph.yaworski@jyaworski-mbpr ~ % git ls-remote https://github.com/kemra102/puppet-auditd.git HEAD
9958c76401085e96bf1b70bc059770b93c2585a0    HEAD
rnelson0 commented 8 years ago

That's a feature I'd like to have but I cannot make any promises on when I will have time. PRs welcome, but you already know this!

Rob Nelson rnelson0@gmail.com

jyaworski commented 8 years ago

I'll see if I can get to it. Would you prefer shelling out or using libgit2?

rnelson0 commented 8 years ago

Doesn't matter to me. Rubbishy solution seems better.

Rob Nelson rnelson0@gmail.com

jyaworski commented 8 years ago

OK. Are you amenable to using the puppetforge bindings too, instead of shelling out to puppet?

rnelson0 commented 8 years ago

Not at this time. Dependency tracking is available but it can be problematic, such as librarian-puppet shows when it gets stuck in a dependency traversal loop. The PMT seems to have a 100% success rate, so though it's time consuming, it also means less bugs to deal with. Maybe we can revisit it later.

Rob Nelson rnelson0@gmail.com

On Thu, Apr 21, 2016 at 6:42 PM, Joseph (Jy) Yaworski < notifications@github.com> wrote:

OK. Are you amenable to using the puppetforge bindings too, instead of shelling out to puppet?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/rnelson0/puppet-generate-puppetfile/issues/25#issuecomment-213147694

rnelson0 commented 6 years ago

@jyaworski As always, I welcome any PRs that add this support! However, I am closing this issue, we can open a new one if either of us finds time to add this. Thanks!