search

rnelson0 / puppet-generate-puppetfile

Generate or update a Puppetfile for use with r10k or librarian-puppet. Optionally, create a fixtures file for rspec-puppet.
92 stars 22 forks source link

[WIP] Add git support. #26

Closed jyaworski closed 7 years ago

jyaworski commented 8 years ago

@rnelson0 this is what I have so far. It's more complex than I imagined.

Comments welcome.

rnelson0 commented 8 years ago

There's a lot new in here - it looks like a mix of rubocop fixes and the feature you're adding. Can we split that into two PRs? Get rubocop working against 0.9.8 as-is, then add the git module stuff. Difficult to follow when the changes are intertwined.

rnelson0 commented 8 years ago

@jyaworski This won't merge anymore. I don't know if you're still interested in working on this but it will require a rebase at least. I am also doing some other work on the code this weekend, so fair warning that you may want to wait to rebase.