search

rnelson0 / puppet-generate-puppetfile

Generate or update a Puppetfile for use with r10k or librarian-puppet. Optionally, create a fixtures file for rspec-puppet.
92 stars 22 forks source link

Process free-form repositories in a Puppetfile for fixtures #62

Closed rnelson0 closed 6 years ago

rnelson0 commented 6 years ago

Parse the data into @repository_data (expand usage later) Add new Puppetfile and rspec tests Update rspec tests and class initialization for accurate testing

Fixes #54

rnelson0 commented 6 years ago

@jearls Awesome, thanks. I've updated my regexp format to be more consistent and include the fixes you found.

rnelson0 commented 6 years ago

@jearls Comment regex updated. Point taken on the optimization comment in slack, I do want to improve the logic of that eventually, but am happy if it works for now. Any other concerns with the current PR?

ghost commented 6 years ago

none that i can see, with the caveat that I've never used this utility :)

rnelson0 commented 6 years ago

I appreciate the review nonetheless!