search

rnelson0 / puppet-generate-puppetfile

Generate or update a Puppetfile for use with r10k or librarian-puppet. Optionally, create a fixtures file for rspec-puppet.
92 stars 22 forks source link

mishandling Uppercase authors modules #65

Open vchepkov opened 6 years ago

vchepkov commented 6 years ago

seems version 1.0.0 mishandling modules with uppercase author name

Here is an example of the input file generated by version 0.11.0

forge 'http://forge.puppetlabs.com'

mod 'WhatsARanjit/node_manager', '0.6.0'
mod 'puppetlabs/inifile', '2.1.1'
mod 'puppetlabs/lvm', '1.0.0'
mod 'puppetlabs/ntp', '7.0.0'
mod 'puppetlabs/stdlib', '4.24.0'

version 1.0.0

mod 'puppetlabs/inifile', '2.1.1'
mod 'puppetlabs/lvm',     '1.0.0'
mod 'puppetlabs/ntp',     '7.0.0'
mod 'puppetlabs/stdlib',  '4.24.0'
mod 'WhatsARanjit/node_manager', '0.6.0'

nodemanager put in the bottom, instead of the top, and version number is misaligned

rnelson0 commented 6 years ago

Whoops, I dropped the insensitive flag when I changed to r%{} style. I will fix this shortly. Thanks!

rnelson0 commented 6 years ago

66 is merged. Is it a problem if I wait on investigating #55 before releasing or can you pull from HEAD right now?

vchepkov commented 6 years ago

Not at all, thank you

rnelson0 commented 4 years ago

v1.1.0 has been released! I am so terribly sorry for the delay, almost 2 years 😱 I promise to not wait that long in the future.