Versions with dashes fail to get parsed

rnelson0 / puppet-generate-puppetfile

Generate or update a Puppetfile for use with r10k or librarian-puppet. Optionally, create a fixtures file for rspec-puppet.

92 stars 22 forks source link

Versions with dashes fail to get parsed #80

Open bartb opened 1 year ago

bartb commented 1 year ago

mod 'dsc-securitypolicydsc', '2.10.0-0-5'

This version format does not get parsed by puppet-generate-puppetfile. When I remove the -0-5 part then it does get parsed by the regex, but then the command puppet module install ... fails because it cannot find the (short) version. It needs the -0-5 part.

rnelson0 commented 11 months ago

@bartb Your fix in #81 has been merged, are you table to test that before I do a release?

bartb commented 11 months ago

Hey Rob, I don't have a Puppet setup at the moment for testing (I left the company for which I made this PR). I'll ask if one of my previous team members can do the testing.

wh33ly commented 4 months ago

@rnelson0 I'm a (ex)college of @bartb I did build the gem from the pullrequest you merged and confirmed it worked.