Open jtovarnak opened 7 years ago
So, I decide to do a bit of proper testing on this and here are my observations:
"seed after hatching" is actually correct I was just converting it to status in wrong order using my previous example "Seed after hatching: 2b304eabL 3f61c787L f36db708L 1f2ad75aL":
STATUS 3: 0x2b304eab
STATUS 2: 0x3f61c787
STATUS 1: 0xf36db708
STATUS 0: 0x1f2ad75a
I don't why I thought that you return seeds in results.txt in 0..3 order - after all 3..0 order makes sense in respect to how that external websites returns current seed after hatching 127 Magikarps. It makes it consistent. So, you can treat my original report as invalid.
I actually had to hatch 127 Magikarps twice - during my first batch I had to go to Festival Plaza to make a trade. I didn't do anything else besides that and still, after having 127 numbers, I didn't get correct seed. Seed returned from the website and then run through update_seed.py was not giving me results I was getting through hatching. While it is possible that I could have made mistake, it is also possible that entering Festival Plaza and/or trading changes nursery seed! After I hatched another batch of 127 Magikarps I now have correct seed and can continue hatching :-)
All in all - everything is fine, you can mark this ticket as invalid.
Are you sure that seed after hatching is calculated correctly?
I wanted to try this method out, so I hatched 127 Magikarps and figured out my original seed. Run it through update_seed.py , got my current seed and put inside config file. Everything fine so far. Then I started playing around with different options in config and since I was getting expected (predicted by your program) result, it confirmed that I indeed have correct seed.
So I actually built a plan to hatch ~10 shinies in quickest way possible, using my current seed and then using "seed after hatching" to calculate next step. First egg matching my parameters was:
Since I was breeding with Ditto I figured why not use Magikarp to speed the process up. So, my breeding Round #1 starts. Funny thing was that I actually also bred shiny Magikarp with correct IV spread along the way :) So, after 208 eggs with Magikarps, I swapped Magikarp parent for the pokemon I wanted to breed. I rejected another 18 eggs and accepted the next one. After I accepted that egg, I immediately removed both parents from daycare. I hatched the egg and it turned out as expected. At this point I saved the game. So, I proceeded to 2nd round in my plan - put Ditto back into nursery together with Magikarp, this time I was supposed to Accept 45 eggs, Reject 1 and then Accept again. Once again, I collected 45 Magikarps, swapped parent, rejected an egg, accepted another, took parents out of nursery and hatched the egg. And it wasn't what I expected! So I thought I might have done something wrong - I did soft reset to get to starting point of Round 2 again. Again, hatched 45 eggs, rejected 1, accepted 1, removed parents and hatched that egg - and I just confirmed that I did nothing wrong the first time, I was not getting what program predicted.
Just to be sure, here is what I was doing:
This was correct, I got exactly what was predicted here. As I said, right after collecting desired egg I removed both parents from nursery.
So, again I took "Seed after hatching: 2b304eabL 3f61c787L f36db708L 1f2ad75aL" and put it into config:
So, using new seed I got 3 results for my next search:
Unfortunately this prediction was not correct. I tried "A45 - R1" twice to be sure I am not miscounting, then also "A44 - R31". Then I even checked some other easily checkable predictions (0IV in certain stat is easy to check for example), and those predictions were wrong as well. This concludes that the seed used for calculation is wrong.
So, the question is - what might have gone wrong? I am 100% sure that no eggs were produced after I collected an egg with my desired outcome. I didn't do anything else in the game either. Did I do something wrong with "Seed after hatching"? I was using it as "STATUS0 STATUS1 STATUS2 STATUS3" as seen in my example above, but maybe I should have converted it as "STATUS3 STATUS2 STATUS1 STATUS0"? Or maybe removing both parents from nursery changes seed as well? I know for sure that changing one parent is safe (hence the Magikarp as placeholder for hatching eggs). I'm also seeing that "Seed after hatching" is same for quite a few results - is that because of Masuda+Shiny Charm?
I really hope I just did something wrong or it's an issue that's easy to fix - it would be shame if I had to hatch 127 magikarps for every single "calculated" pokemon.
Besides that - great job, it is really helpful.