rnheroes / react-native-toastable

🍞 Blazingly fast and fully customizable Toaster component for React Native
https://www.npmjs.com/package/react-native-toastable
MIT License
96 stars 4 forks source link

[Request] make it modal compatible #1

Open AlejandroGutierrezB opened 1 year ago

AlejandroGutierrezB commented 1 year ago

Hey, first of all really nice job on this package.

I encountered it after I saw your comment on react-native-toast-message, and wheres this solves that issue, your package is not showing on the modal view.

You can render a toast on a modal view, but if you do so the queuing loses track and you can't render the global one.

Maybe I am missing something and it can be done, if so could you provide an example.

If not, I would say that is a very important feature to support.

Thanks again and have a nice day!

enestatli commented 1 year ago

Hey, first of all really nice job on this package.

I encountered it after I saw your comment on react-native-toast-message, and wheres this solves that issue, your package is not showing on the modal view.

You can render a toast on a modal view, but if you do so the queuing loses track and you can't render the global one.

Maybe I am missing something and it can be done, if so could you provide an example.

If not, I would say that is a very important feature to support.

Thanks again and have a nice day!

Hello, thank you.

We are working on this recently, I hope we can make it.

Right now you can wrap Toaster with FullWindowOverlay imported from react-native-screens

import { FullWindowOverlay } from 'react-native-screens';
import Toastable from 'react-native-toastable';

<FullWindowOverlay>
   <Toastable  />
</FullWindowOverlay>

Note that FullWindowOverlay works only for iOS

Aleksandern commented 1 year ago

@enestatli Hello. Any news about the modal issue?

mozzius commented 11 months ago

Hello, thank you.

We are working on this recently, I hope we can make it.

Right now you can wrap Toaster with FullWindowOverlay imported from react-native-screens

import { FullWindowOverlay } from 'react-native-screens';
import Toastable from 'react-native-toastable';

<FullWindowOverlay>
   <Toastable  />
</FullWindowOverlay>

Note that FullWindowOverlay works only for iOS

This is not an acceptable solution - it completely breaks VoiceOver accessibility. Would love to see a better solution