search

rnicoll / cate

Cross-chain Atomic Transaction Engine
MIT License
34 stars 19 forks source link

Confirm the password a second time in case of typos #8

Closed Qu3ntin0 closed 8 years ago

rnicoll commented 8 years ago

Thanks for that, mostly looks good. Could you expand the import lines again, back to how they were, though? I know it looks neater, however it also makes it a nightmare to track down class name collisions. I'll add some notes on code style to the README in a second.

Qu3ntin0 commented 8 years ago

The auto import by the IDE (IntelliJ) was the issue. I'll make sure to look out for that and to browse the code style before making pull requests.

rnicoll commented 8 years ago

Great, thanks. Could you squash the two commits (if you're on the command line, "git rebase -i HEAD~2" and then change "pick" to "squash" on the second commit) together into a single commit please? You'll also have to do a force push ("git push -f origin ") to push the changes afterwards.

rnicoll commented 8 years ago

Tested, works well, thanks!

dodidgy10 commented 5 years ago

Yees