search

rniemeyer / knockout-classBindingProvider

An alternate binding provider for Knockout that allows you to define your bindings in a JavaScript object and key into it from the markup.
MIT License
101 stars 27 forks source link

Add classes array as second argument to binding function #7

Closed drosen0 closed 12 years ago

drosen0 commented 12 years ago

See discussion in #1.

drosen0 commented 12 years ago

So the change became much simpler. The first 3 commits are part of #2. There are probably specs to write, which I can take care of if you'd like.

rniemeyer commented 12 years ago

I'll write the specs for this feature. Thanks.

rniemeyer commented 12 years ago

OK- this one has been merged.

rniemeyer commented 12 years ago

@drosen0 Thanks again for the work on these pull requests and the discussion of possible implementations!

drosen0 commented 12 years ago

Cool, the specs good too. Just wondering, since this is the first time I've had multiple pulls out on a project simultaneously... did I do it right, with the separate pulls? Or is there a better way that would keep the different pulls in a single issue?

rniemeyer commented 12 years ago

I think that it was fine. You would want them in different topic branches like you had them and then you can just reference them by # between pull requests like you did. Probably not a normal scenario.