search

rniemeyer / knockout-jqAutocomplete

knockout-jqAutocomplete is a Knockout.js plugin designed to work with jQuery UI's autocomplete widget.
MIT License
49 stars 20 forks source link

Fix issue with default text in input value #11

Closed rposener closed 9 years ago

rposener commented 9 years ago

Support correct default text when using local object arrays in the element's value. This honors the inputProp, labelProp, and valueProp as noted in the documentation when initializing.

rniemeyer commented 9 years ago

@rposener - can you also update the unit tests around update to test the new functionality, if you can?

rposener commented 9 years ago

I agree - will update based on your comments, and add unit tests.

rniemeyer commented 9 years ago

Thanks @rposener . This is a good change.

rposener commented 9 years ago

Just checked in the tests and had to update a few bits of logic in the update to get all tests passing properly. Thanks!

rposener commented 9 years ago

@rniemeyer let me know if you need any more to incorporate this change from me. It's working great in my project.

rniemeyer commented 9 years ago

@rposener - I think it looks good. Just need some time to go over it closer. Should be good to go though. Thanks!

rniemeyer commented 9 years ago

Thanks @rposener. This one is merged.