Improve clean-up handling

rniemeyer / knockout-postbox

A small library that uses Knockout's native pub/sub capabilities to facilitate decoupled communication between separate view models or components.

MIT License

350 stars 55 forks source link

Improve clean-up handling #43

Closed gkubisa closed 7 years ago

gkubisa commented 7 years ago

Added stopSyncingWith
Added dispose to clean up all postbox subscriptions in addition to any default clean-up logic (for computed observables).

rniemeyer commented 7 years ago

@gkubisa - From a quick glance, these changes look legit to me. I would do a minor version bump though ( to 0.6.0). Will review thoroughly, when I have a chance.

gkubisa commented 7 years ago

Thanks @rniemeyer :+1:

rniemeyer commented 7 years ago

@gkubisa - This is merged. Great work! Tests and docs were excellent.