search

rniemeyer / knockout-sortable

A Knockout.js binding to connect observableArrays with jQuery UI sortable functionality
MIT License
547 stars 128 forks source link

Moving Issue #100

Closed OmarKhanfer closed 10 years ago

OmarKhanfer commented 10 years ago

There is a problem when you sort the item quickly, there are some items removed from the dom, but the data in the observable exist,

bago commented 10 years ago

Can you test the last code from https://github.com/bago/knockout-sortable/ ? Ryan and I are working at fixing #104 and maybe the changes also fix this one.

OmarKhanfer commented 10 years ago

Dear Stefano,

I tested it, last time it has a problem, in the dragging many times some items will remove. but now i guess it has been fixed.

Thanks and Regards Omar

On Mon, Jun 16, 2014 at 9:22 PM, Stefano Bagnara notifications@github.com wrote:

Can you test the last code from https://github.com/bago/knockout-sortable/ ? Ryan and I are working at fixing #104 https://github.com/rniemeyer/knockout-sortable/issues/104 and maybe the changes also fix this one.

— Reply to this email directly or view it on GitHub https://github.com/rniemeyer/knockout-sortable/issues/100#issuecomment-46207673 .

Thanks and Regards

Omar Najeeb Al Jaber

Mobile: +971 55 751 2019

E-mail: omar.aljaber@gmail.com omar.aljaber@tatweersoftware.com

Blog: omaraljaber.info

OmarKhanfer commented 10 years ago

Still has bugs.

Thanks and Regards Omar

On Tue, Jun 17, 2014 at 8:05 PM, Ryan Niemeyer notifications@github.com wrote:

Closed #100 https://github.com/rniemeyer/knockout-sortable/issues/100.

— Reply to this email directly or view it on GitHub https://github.com/rniemeyer/knockout-sortable/issues/100#event-132254184 .

Thanks and Regards

Omar Najeeb Al Jaber

Mobile: +971 55 751 2019

E-mail: omar.aljaber@gmail.com omar.aljaber@tatweersoftware.com

Blog: omaraljaber.info

bago commented 10 years ago

"Still has bugs" won't help fixing them ;-) I'm not the mantainer of this project but you should provide more informations and allow them to reproduce the issue/bug if you hope they will take the time to work on it.

The best way to help them is to create a jsbin/jsfiddle to show the issue.

Furthermore, your initial comment was about "sort item quickly": 1) is is about moving the mouse fast? or making multiple moves in rapid sequence? 2) How much is quickly? 3) Does it happens on multiple browsers or only specific browsers? 4) Does it happens on multiple computers?

Reproducibility needs knowledge.