search

rniemeyer / knockout-sortable

A Knockout.js binding to connect observableArrays with jQuery UI sortable functionality
MIT License
548 stars 128 forks source link

Knockout 3.4 deferUpdates #166

Closed carlosagsmendes closed 8 years ago

carlosagsmendes commented 8 years ago

Hi @rniemeyer ,

I've run into some issues when using deferUpdates on ko 3.4 with knockout-sortable. The afterMove function is called only once for each element: sample fiddle

Apparently, setting the strategyMove to true seems to fix the problem: sample fiddle

I realized that you are handling deferred updates for the @mbest plugin

My understanding is that we also need to do it for the deferred updates implementation on ko 3.4. Does it make sense?

This seems to fix the problem both for the strategyMove=true and strategyMove=false

rniemeyer commented 8 years ago

@carlosagsmendes - Thanks for the PR! This has been incorporated into v0.14.0.

carlosagsmendes commented 8 years ago

Thank you Ryan