search

rniemeyer / knockout-sortable

A Knockout.js binding to connect observableArrays with jQuery UI sortable functionality
MIT License
547 stars 128 forks source link

Problem after upgrading ko to 3.5.1 #203

Closed pablolmedorado closed 4 years ago

pablolmedorado commented 4 years ago

First of all, I'd like to thank you for such an useful library.

I think I've found an error after upgrading knockout version to 3.5.1

As far as I know, the "object" binding format doesn't work. If you use the observableArray as the binding value, it works as always.

I've created a jsfiddle with the error: https://jsfiddle.net/6w74czhp/5/

I've tested the example with both 1.1.1 and 2.0.0 versions of your library with the same result. It works with 3.5.0 but not with 3.5.1.

Thanks in advance.

fastfasterfastest commented 4 years ago

Probably duplicate of https://github.com/rniemeyer/knockout-sortable/issues/199

rniemeyer commented 4 years ago

Version 1.2.0 is out there that includes a fix for this issue. Updated fiddle: https://jsfiddle.net/n1egw98b/

Thanks!

pablolmedorado commented 4 years ago

Amazing response time! Thank you so much!