search

rniemeyer / knockout-sortable

A Knockout.js binding to connect observableArrays with jQuery UI sortable functionality
MIT License
547 stars 128 forks source link

JS error introduced by v1.2.1 "Fixed draggable and droppable disposal" #207

Closed pshbot closed 3 years ago

pshbot commented 3 years ago

When I use v1.2.1, I get the following JS error in my app:

knockout-sortable.js:431 Uncaught ReferenceError: $element is not defined

image

If I roll back to v1.2.0, the error goes away. Looks like this issue was introduced by this change.

I think it can be fixed by inserting a line at :431 (and :485) like

const $element = $(element);
rniemeyer commented 3 years ago

@pshbot - thanks - fixed in 1.2.2.