rnkn / fountain-mode

Emacs major mode for screenwriting in Fountain plain-text markup
https://fountain-mode.org
GNU General Public License v3.0
393 stars 15 forks source link

fountain-export-command: optionally prompt to save buffer #126

Closed ZungBang closed 4 years ago

ZungBang commented 4 years ago

Was actually surprised when the exported pdf was different than the buffer's contents ...

rnkn commented 4 years ago

This will prompt to save every unsaved buffer though, which isn't good. You can provide a lambda to the PRED argument to limit to the current buffer.

Also there are cases when the user wants to avoid saving the buffer (i.e. when not visiting a file) so put this in the else-form for (if use-stdin ...).

ZungBang commented 4 years ago

gotcha - ditched save-some-buffers in favor of a more direct approach

rnkn commented 4 years ago

p.s. I've reverted the change the causes the build to fail on Emacs 24, so if you'd prefer your PR checks to pass you can pull that down, but up to you.