search

rnpgp / chocolatey-rnp

Chocolatey package for RNP
3 stars 1 forks source link

Create Chocolatey / Windows RNP package #1

Closed ronaldtse closed 4 years ago

ronaldtse commented 4 years ago

Ping @camobap795

CAMOBAP commented 4 years ago

@ronaldtse could you please clarify where the software locates, also please give me write access to this repo (and snap one)

ronaldtse commented 4 years ago

The software repo is at https://github.com/rnpgp/rnp/ . You have access.

ronaldtse commented 4 years ago

@rrrooommmaaa would you have time to take on this after Homebrew? Thanks!

rrrooommmaaa commented 4 years ago

@ronaldtse Of course, I'll take it.

ronaldtse commented 4 years ago

Perfect, appreciate it!

rrrooommmaaa commented 4 years ago

@ronaldtse Chocolatey package usually contains a script to download .exe (and check sha256 checksum) from some site. Where would our MinGW binaries be located?

rrrooommmaaa commented 4 years ago

Though it's recommended to include files in the package, So I can add exe's into the package.

ronaldtse commented 4 years ago

@rrrooommmaaa can we have the MinGW binaries uploaded to bintray?

rrrooommmaaa commented 4 years ago

@ronaldtse I think we should have mingw and msys2 packages as dependencies in chocolatey. I'm currently working in this direction. I was talking about our own binaries: rnp.exe and rnpkeys.exe. There is a practice to make user accept license before downloading binaries. If that's not required, we can bundle the binaries inside the package.

ronaldtse commented 4 years ago

There is a practice to make user accept license before downloading binaries. If that's not required, we can bundle the binaries inside the package.

I think it is not necessary for users to interactively accept the license for downloading the binaries, so let's just bundle them.

Thanks!

rrrooommmaaa commented 4 years ago

@ronaldtse We would need MSYS2 dlls to run the binaries. On my build system there were about 80Mbytes downloaded and installed (including zlib1, libjson-c and libbz2) for building the RNP. So we can either: 1) pack them all into Chocolatey package, 2) download them as zip from some repo. 3) try to rebuild them using dependencies with exact versions. Which would be more appropriate and won't infringe on licenses? I have a script to deploy MSYS2 and pacman updates handy from another project.

ronaldtse commented 4 years ago

@rrrooommmaaa @dewyatt @ni4 I think the best way to distribute on Windows is to statically compile in json-c and zlib (no Chocolately packages), and depend on the bzip2 Chocolatey package (comes with bzip2.dll).

Thoughts?

ni4 commented 4 years ago

@ronaldtse @rrrooommmaaa I tried to link rnp statically but got some linking problems so filed an issue rnpgp/rnp#996, also we had rnpgp/rnp#888.

I think it would be better to link everything statically if this is allowed by license(s).

ronaldtse commented 4 years ago

@ni4 I believe linking everything statically (the libraries we use) is allowed by license as long as we distribute with the license notice as part of the distribution package.

ronaldtse commented 4 years ago

Wait it's not created yet. Will need to upload package to Chocolatey.

CAMOBAP commented 4 years ago

@ronaldtse let me know if I can help somehow

rrrooommmaaa commented 4 years ago

@ronaldtse GHA?

ronaldtse commented 4 years ago

@rrrooommmaaa you mean we should update GHA?

rrrooommmaaa commented 4 years ago

@rrrooommmaaa you mean we should update GHA?

We don't have any GHA in this repository yet. So the task is actually to add GHA in this repository?

It will also close #4

ronaldtse commented 4 years ago

@rrrooommmaaa let's close this task and open two new ones: