rnpgp / homebrew-rnp

Homebrew formula for rnp
4 stars 1 forks source link

homebrew expects botan2, but botan version is 3.0 now... #37

Open shemeshg opened 1 year ago

shemeshg commented 1 year ago

Error message

Could NOT find Botan2 (missing: BOTAN2_LIBRARY BOTAN2_INCLUDE_DIR)

Error log

macos@macoss-Mac-mini ~ % brew tap rnpgp/rnp
==> Tapping rnpgp/rnp
Cloning into '/usr/local/Homebrew/Library/Taps/rnpgp/homebrew-rnp'...
remote: Enumerating objects: 387, done.
remote: Counting objects: 100% (167/167), done.
remote: Compressing objects: 100% (66/66), done.
remote: Total 387 (delta 65), reused 158 (delta 64), pack-reused 220
Receiving objects: 100% (387/387), 55.94 KiB | 406.00 KiB/s, done.
Resolving deltas: 100% (124/124), done.
Tapped 1 formula (19 files, 87.3KB).
macos@macoss-Mac-mini ~ % brew install rnp
==> Downloading https://formulae.brew.sh/api/formula.jws.json
######################################################################### 100.0%
==> Downloading https://formulae.brew.sh/api/cask.jws.json
######################################################################### 100.0%
==> Fetching dependencies for rnpgp/rnp/rnp: python@3.11, botan and json-c
==> Fetching python@3.11
==> Downloading https://ghcr.io/v2/homebrew/core/python/3.11/manifests/3.11.4
######################################################################### 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/python/3.11/blobs/sha256:c81561
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sh
######################################################################### 100.0%
==> Fetching botan
==> Downloading https://ghcr.io/v2/homebrew/core/botan/manifests/3.0.0
######################################################################### 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/botan/blobs/sha256:859aab2d6e57
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sh
######################################################################### 100.0%
==> Fetching json-c
==> Downloading https://ghcr.io/v2/homebrew/core/json-c/manifests/0.16
######################################################################### 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/json-c/blobs/sha256:2d032280aa3
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sh
######################################################################### 100.0%
==> Fetching rnpgp/rnp/rnp
==> Downloading https://github.com/rnpgp/rnp/archive/refs/tags/v0.16.3.tar.gz
==> Downloading from https://codeload.github.com/rnpgp/rnp/tar.gz/refs/tags/v0.1
              #    #    #     #                                         -=O=-
==> Installing rnp from rnpgp/rnp
==> Installing dependencies for rnpgp/rnp/rnp: python@3.11, botan and json-c
==> Installing rnpgp/rnp/rnp dependency: python@3.11
==> Pouring python@3.11--3.11.4.monterey.bottle.tar.gz
==> /usr/local/Cellar/python@3.11/3.11.4/bin/python3.11 -m ensurepip
==> /usr/local/Cellar/python@3.11/3.11.4/bin/python3.11 -m pip install -v --no-d
🍺  /usr/local/Cellar/python@3.11/3.11.4: 3,286 files, 61.9MB
==> Installing rnpgp/rnp/rnp dependency: botan
==> Pouring botan--3.0.0.monterey.bottle.tar.gz
🍺  /usr/local/Cellar/botan/3.0.0: 244 files, 21.0MB
==> Installing rnpgp/rnp/rnp dependency: json-c
==> Pouring json-c--0.16.monterey.bottle.tar.gz
🍺  /usr/local/Cellar/json-c/0.16: 32 files, 320.4KB
==> Installing rnpgp/rnp/rnp
==> cmake -S . -B build
Last 15 lines from /Users/macos/Library/Logs/Homebrew/rnp/01.cmake:
-- Found BZip2: /Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/usr/lib/libbz2.tbd (found version "1.0.8")
-- Looking for BZ2_bzCompressInit
-- Looking for BZ2_bzCompressInit - found
-- Found ZLIB: /Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/usr/lib/libz.tbd (found version "1.2.11")
-- Found JSON-C: /usr/local/lib/libjson-c.dylib (found suitable version "0.16", minimum required is "0.11")
CMake Error at /usr/local/Cellar/cmake/3.26.4/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Botan2 (missing: BOTAN2_LIBRARY BOTAN2_INCLUDE_DIR)
  (Required is at least version "2.14.0")
Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.26.4/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  cmake/Modules/FindBotan2.cmake:100 (find_package_handle_standard_args)
  src/lib/CMakeLists.txt:35 (find_package)

-- Configuring incomplete, errors occurred!

If reporting this issue please do so at (not Homebrew/brew or Homebrew/homebrew-core):
  https://github.com/rnpgp/homebrew-rnp/issues

These open issues may also help:
Provide bottle(s) with rnp brew formulae https://github.com/rnpgp/homebrew-rnp/issues/33
Update formula to install rnp.dylib (or add rnp-dev). https://github.com/rnpgp/homebrew-rnp/issues/29
macos@macoss-Mac-mini ~ % brew untap rnpgp/rnp
Untapping rnpgp/rnp...
Untapped 1 formula (20 files, 88.6KB).

Botan version

macos@macoss-Mac-mini ~ % brew info botan
==> botan: stable 3.0.0 (bottled), HEAD
Cryptographic algorithms and formats library in C++
https://botan.randombit.net/
/usr/local/Cellar/botan/3.0.0 (244 files, 21.0MB) *
  Poured from bottle using the formulae.brew.sh API on 2023-06-17 at 17:34:01
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/botan.rb
License: BSD-2-Clause
==> Dependencies
Build: pkg-config ✔
Required: python@3.11 ✔, sqlite ✔
==> Options
--HEAD
    Install HEAD version
==> Analytics
install: 0 (30 days), 0 (90 days), 0 (365 days)
install-on-request: 0 (30 days), 0 (90 days), 0 (365 days)
build-error: 0 (30 days)
macos@macoss-Mac-mini ~ %
shemeshg commented 1 year ago

Compiling from main DOES work.

So it is just a matter of releasing new version...

Notice that

This formula is referencing

url "https://github.com/rnpgp/rnp/archive/refs/tags/v0.16.3.tar.gz"

and not 0.17.0

However, 0.17.0 does NOT work either, and it will not solve the problem.

What we need is hopefully soon, a new release from Main.

this will probably solve #33 also

Thanks

ni4 commented 1 year ago

@shemeshg thanks for opening this issue. Botan3 support was added only recently to the main, and will be included into the next release. Sometimes homebrew rushes with including only the latest version of libraries/tools.

ronaldtse commented 3 months ago

@ni4 perhaps it's time to update this formula!