search

rnpgp / rnp

RNP: high performance C++ OpenPGP library used by Mozilla Thunderbird
https://www.rnpgp.org
Other
194 stars 55 forks source link

Duplicated function `test_rnp_list_packets` in CLI tests #1201

Closed antonsviridenko closed 4 years ago

antonsviridenko commented 4 years ago

Description

Function test_rnp_list_packets is defined twice in the same class 'Misc'.

Steps to Reproduce

  1. https://github.com/rnpgp/rnp/blob/master/src/tests/cli_tests.py#L1536
  2. https://github.com/rnpgp/rnp/blob/master/src/tests/cli_tests.py#L1611

Expected Behavior

I think that second instance of this function was intended to have some different name and it was duplicated by mistake.

ni4 commented 4 years ago

Yeah, second one should be named like test_rnp_list_packets_edge_cases().