Portability issues

[dewyatt]

See discussion in: https://github.com/riboseinc/rnp/pull/117

I guess the proper way to handle this is to update the autotools bits. My knowledge there is lacking. It defaults to --std=gnu99 locally for me, which is not quite enough for clang (gnu11 would probably work).

I should probably avoid overriding --std and defining _GNU_SOURCE explicitly in the CI scripts.

Some of the portability concerns I see are:

• getpass
• mkstemp
• mkdtemp
• strcasemp
• MAP_FILE
• nftw

[ronaldtse]

Aha so this is the list of portability concerns!

Let me add the following too mentioned in #9 .

• asprintf
• vasprintf (only used in obuf_printf within libverify.c)

UPDATED: all asprintf calls were already removed by @shaunwheelhouse .

[dewyatt]

@ronaldtse This reminds me, do you have an official list of platforms we should aim to support?

[ronaldtse]

@dewyatt the official list of platforms is listed in the README now.

[ni4]

@dewyatt looks like these functions are removed or handled in other way, so should we close this now?

[dewyatt]

@ni4 Yes indeed