Closed kaie closed 4 years ago
I also have this error when trying to build with MSC compiler (#997) Perhaps, it's more stringent than GNU's
That's why we should definitely have workflow which copies TB build steps. I'll take a look tomorrow, at the moment it looks a bit mystic. This could be related but not sure yet: https://stackoverflow.com/questions/53168836/does-visual-studio-2017-need-an-explicit-move-constructor-declaration
@rrrooommmaaa @kaie Does this patch helps on this issue: https://github.com/rnpgp/rnp/pull/1250/files ?
I've started a test build to check it: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=da01a700bb6f3519b57f66693727caa6874ee195
The windows build passed!
Can you suggest how Thunderbird should pick up this fix? Do you want TB to update to a newer snapshot that includes this fix?
Or is it time to consider a stable branch, based on the 2020-08-03 baseline, plus fixes?
Great! We had some PRs merged since 08-03, and those are mostly about bug fixing. If this doesn't interfere with audit I'd suggest to pick all of those commits, if it does - then just put this fix on top of 08-03, and delay picking up other commits till audit is finished.
who should make that decision? (interfere or doesn't interfere)
I've started a build for linux/macos, just to doublecheck this change builds on those platforms, too. https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=357a973452230c31ab19fa9ac2448074a734d49b
who should make that decision? (interfere or doesn't interfere)
Hm, I think we should ask guys from c53. Anyway, as I correctly understand your beta build process, it's okay to have one build for them and another development build which is based on latest sources?
linux/macos built ok
Closing this since issue is fixed.
I tried to build the snapshot from end-of-day 2020-08-03. Building as part of Thunderbird for Windows results in the following build error: