Support macOS Big Sur on Mac M1

rnpgp / rnp

RNP: high performance C++ OpenPGP library used by Mozilla Thunderbird

https://www.rnpgp.org

Other

199 stars 55 forks source link

Support macOS Big Sur on Mac M1 #1351

Open ronaldtse opened 3 years ago

ronaldtse commented 3 years ago

We should support M1 running of RNP. This will be a need for TB as well.

Ping @dewyatt @ni4

Here's a document that describes installation of Homebrew on M1: https://github.com/mikelxc/Workarounds-for-ARM-mac

ni4 commented 3 years ago

Wondering whether GHA would support ARM CPUs (or whether it is technically possible at all?).

@ronaldtse Btw, shouldn't we try again to add homebrew formula for the rnp?

ronaldtse commented 3 years ago

Wondering whether GHA would support ARM CPUs (or whether it is technically possible at all?).

I hope they will? They probably should.

@ronaldtse Btw, shouldn't we try again to add homebrew formula for the rnp?

Yes we absolutely should! Could you help with it?

ni4 commented 3 years ago

Yes we absolutely should! Could you help with it?

Ok, sure.

ni4 commented 3 years ago

@ronaldtse Looks like we don't have enough watchers at the moment - in January homebrew required 30 watchers. And probably it would be good to (finally) release 0.14 and then try to add it to the homebrew, what do you think?

ronaldtse commented 3 years ago

@ni4 interesting we have more stars and forks than watchers... yeah let's wait for a bit then.

ronaldtse commented 2 years ago

Waiting for https://github.com/actions/virtual-environments/issues/2187 .

Apparently GitHub is looking into this for 2022... (https://github.com/actions/virtual-environments/issues/2187#issuecomment-939033228)
GitHub runners depend on the latest dot-NET release that will include M1 support, estimated release tomorrow (Nov 9, 2021: https://github.com/actions/runner/issues/805#issuecomment-956193568)

ronaldtse commented 2 years ago

It is also possible to cross-compile from Intel:

https://stackoverflow.com/questions/65361672/build-apple-silicon-binary-on-intel-machine

ni4 commented 2 years ago

I can take a look at this after the v0.16.0 release. Given that I recompiled macOS Objective-C apps (including some frameworks) for the x64/arm64 binary year ago don't see what can go wrong with rnp dylib.

ronaldtse commented 2 years ago

Thanks @ni4 !

ni4 commented 2 years ago

This is definitely possible via CMAKE_OSX_ARCHITECTURES , however that would need to build Botan/JSON-C with two architectures as well.

ni4 commented 5 months ago

@ronaldtse Given that GitHub now has macOS runners or arm/M1, I guess we could close this issue? Or should we wait till rnp is included to homebrew?