search

rnpgp / rnp

RNP: high performance C++ OpenPGP library used by Mozilla Thunderbird
https://www.rnpgp.org
Other
192 stars 54 forks source link

cli_tests fail when running in parallel on Windows/MSVC #1394

Open rrrooommmaaa opened 3 years ago

rrrooommmaaa commented 3 years ago

Description

Looks like one of cli_tests consistently hangs on 2 cores on MSVC build.

Let's try and run cli_tests with -j1 and others with -j${CTEST_PARALLEL}, maybe? Is there an easy filter to run all tests except those matching the pattern?

ni4 commented 3 years ago

@rrrooommmaaa Is it really a hang, not a timeout? cli_tests.Encryption test is the huge one, with a lot of key generations and so on.

rrrooommmaaa commented 3 years ago

It hangs on various tests, not always on cli_tests.Encryption, probably some random cli test becomes a victim. Sometime https://github.com/rnpgp/rnp/pull/1393/checks?check_run_id=1747921807 Compression passes in 369.18 sec, Encryption hangs Sometime https://github.com/rnpgp/rnp/pull/1387/checks?check_run_id=1734829333 Encryption passes in 496.60 sec, Compression hangs. Given that timeout is 3000 -- it does look like a hang (probably in botan library again). @dewyatt Can you imagine what the reason can be?

ni4 commented 3 years ago

@rrrooommmaaa But it passed all CI when CTEST_PARALLEL was introduced?

rrrooommmaaa commented 3 years ago

Maybe it passed with old botan library

ni4 commented 3 years ago

Yeah, looks like some locking occurs, see output at https://github.com/ni4/rnp/pull/12 If Compression test is run alone it takes ~270 seconds to finish.