search

rnpgp / rnp

RNP: high performance C++ OpenPGP library used by Mozilla Thunderbird
https://www.rnpgp.org
Other
192 stars 54 forks source link

Create Windows installer for RNP via CI #1405

Open ronaldtse opened 3 years ago

ronaldtse commented 3 years ago

From @antonsviridenko:

I think we can build installer binary, maybe using NSIS, and it will install files into C:\Program Files\rnp\ or some other place, like it is traditionally done on Windows.

e.g. https://github.com/marketplace/actions/makensis

Originally posted by @ronaldtse in https://github.com/rnpgp/rnp/issues/1387#issuecomment-776495597

ronaldtse commented 2 years ago

@maxirmx could you please help with this? Thanks!

maxirmx commented 2 years ago

@ronaldtse I believe some clarification is required

  1. Native or mingw or two installers ?
  2. Installer normally have some prelude. At least a screen saying "Hello, thank you for choosing, please read and accept license agreement" ... I need at least some general guidance.
  3. What do we want to install ? Application ? SDK (library, headers, samples, link to the docs, ...)? Both ?
ronaldtse commented 2 years ago

@maxirmx

  1. What would you recommend?
  2. Yes, we will be able to provide that initial paragraph.
  3. We want to install the CLI tools and the library/headers. For documentation they can find on our website at rnpgp.org.
maxirmx commented 2 years ago

@ronaldtse I would do native, if it was my choice. However, I know that I adhere to extreme position that is not shared by everyone.

antonsviridenko commented 2 years ago

Installer normally have some prelude. At least a screen saying "Hello, thank you for choosing, please read and accept license agreement" ... I need at least some general guidance.

@maxirmx

I think that most suitable Windows installer building tool is NSIS, as already mentioned. It provides welcome screen, license text dialogs and so on. You only need to write NSIS script and call nsis compiler.

maxirmx commented 2 years ago

@antonsviridenko Thank you I am asking about text/design of welcome screen and license itself. I do not think that NSIS already has these texts for RNP

maxirmx commented 2 years ago

ref https://github.com/rnpgp/rnp/issues/1402

ronaldtse commented 2 years ago

In any case we need to provide an MSI or MSX file so that managed installs can happen on Windows.

The text could be: "Welcome to the RNP installer. You will be guided through the steps necessary to install RNP, including its command-line tool and its software libraries."

The license should be taken from the LICENSE file we have at repo root.