Closed ribose-jeffreylau closed 3 years ago
Perhaps this is just historical oversight? Would be strange if GPG behaves differently under gcc vs clang.
Historically we forced the sanitize CI job to use clang because, at the time, the sanitizers were not as well supported with gcc. We also used to build all library dependencies with sanitizers I think (not sure when we dropped this - maybe a step backwards...).
Regardless, I don't see an issue with sticking to gcc for building gnupg as we only consume it as an executable.
(I'm not sure if that answers your questions...let me know)
I guess to summarize, feel free to unset those for the gnupg build portion of CI.
@dewyatt Thanks for the clarification! This has answered the question.
I have been working on including more platforms to build rnp on, and found that GPG and/or its components (the more recent versions) would fail to build on some platforms with
BUILD_MODE = sanitize
. I'm wondering if this is due to the fact thatsanitize
would make GPG build withclang
&clang++
, and that it happened to have issues with newer codes? The second question is, is this intended?The following lines set
CC
andCXX
globally in the workflow: https://github.com/rnpgp/rnp/blame/d440935cd257457afc865413070f7b4c4373c535/ci/env-common.inc.sh#L14-L17ping @dewyatt