search

rnpgp / rnp

RNP: high performance C++ OpenPGP library used by Mozilla Thunderbird
https://www.rnpgp.org
Other
198 stars 55 forks source link

macOS compatibility broken on updates #214

Closed ronaldtse closed 7 years ago

ronaldtse commented 7 years ago

Running build.sh on macOS gives this error.

checking whether BOTAN_HAS_PGP_S2K is declared... no
configure: error: Botan build is missing a required feature

Obviously this is due to botan version (and that S2K isn't released yet), but there ought to be a way to make this work properly.

ni4 commented 7 years ago

It doesn't work if 'brew install botan', however works fine if build botan from sources, using the master branch.

ronaldtse commented 7 years ago

Yes @ni4 , currently rnp requires botan from its latest master branch, but @randombit says he will have everything merged by botan 2.2, so we can probably rely on normal botan then.

ronaldtse commented 7 years ago

@ni4 we actually have a homebrew tap + formula here https://github.com/riboseinc/homebrew-rnp . Perhaps you could help maintain it so as to provide a one-liner install for rnp on macOS?

ni4 commented 7 years ago

@ronaldtse Sure, I can be responsible for this.

ni4 commented 7 years ago

@ronaldtse Maybe we can close this since homebrew formula works fine now?

ronaldtse commented 7 years ago

Yes indeed. Thanks!