search

rnpgp / rnp

RNP: high performance C++ OpenPGP library used by Mozilla Thunderbird
https://www.rnpgp.org
Other
202 stars 55 forks source link

Ignore pushes to version.txt for most of the CI #2230

Closed ni4 closed 6 months ago

ni4 commented 6 months ago

And check version.txt contents if it is changed. Fixes #2226

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.64%. Comparing base (3c42d77) to head (3afb738).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2230 +/- ## ======================================= Coverage 83.64% 83.64% ======================================= Files 107 107 Lines 23168 23168 ======================================= Hits 19378 19378 Misses 3790 3790 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ni4 commented 6 months ago

@ronaldtse Thanks! And I should also make newly added CI check work :-D Seems something went wrong with version.txt check

ni4 commented 6 months ago

Thanks @ni4!

Is it correct to say that nix.yml and ubuntu.yml are left out because we want them to run when version.txt changes?

Ubunty was left to have at least one runner in case something may go wrong due to changes commited, nix was just overlooked :) But let's left it as well.

ni4 commented 6 months ago

All is green + two approvals, so merging.