Closed maxirmx closed 5 months ago
Attention: Patch coverage is 66.66667%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 83.58%. Comparing base (
657b188
) to head (e0790a2
).
Files | Patch % | Lines |
---|---|---|
src/librekey/key_store_g10.cpp | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@maxirmx JFYI, CI is now broken due to Botan head issue. I'm fixing it via the PR #2240
@maxirmx JFYI, CI is now broken due to Botan head issue. I'm fixing it via the PR #2240
Thank you I struggling with python upgrade on MacOs/ I guess it is something different
lgtm.
There is still https://github.com/rnpgp/rnp/blame/main/src/lib/types.h#L75
I guess one needs to include the sexp.h
header before the types.h
header?
@ni4 , I think we shall merge it on top of #2240
@maxirmx Yeah, like a bunch of other PRs :) Waiting for the second approval cc @ronaldtse
@maxirmx Now PR with CI fixes is merged, could you please rebase this? Or I can do that as well.
@maxirmx ....and one more thing - macos-11 runner deprecation at the end of June, with scheduled failures at Jun, 24 :) https://github.com/rnpgp/rnp/pull/2239/commits/fb22831a65e0cef3ddaa37b53ea2151054387ea1
Closes #2241