search

rnpgp / rnp

RNP: high performance C++ OpenPGP library used by Mozilla Thunderbird
https://www.rnpgp.org
Other
198 stars 55 forks source link

libsexpp updated to 0.8.8 #2242

Closed maxirmx closed 3 months ago

maxirmx commented 4 months ago

Closes #2241

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.58%. Comparing base (657b188) to head (e0790a2).

Files Patch % Lines
src/librekey/key_store_g10.cpp 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2242 +/- ## ========================================== - Coverage 83.58% 83.58% -0.01% ========================================== Files 107 107 Lines 23174 23167 -7 ========================================== - Hits 19371 19364 -7 Misses 3803 3803 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ni4 commented 3 months ago

@maxirmx JFYI, CI is now broken due to Botan head issue. I'm fixing it via the PR #2240

maxirmx commented 3 months ago

@maxirmx JFYI, CI is now broken due to Botan head issue. I'm fixing it via the PR #2240

Thank you I struggling with python upgrade on MacOs/ I guess it is something different

maflcko commented 3 months ago

lgtm.

There is still https://github.com/rnpgp/rnp/blame/main/src/lib/types.h#L75

I guess one needs to include the sexp.h header before the types.h header?

maxirmx commented 3 months ago

@ni4 , I think we shall merge it on top of #2240

ni4 commented 3 months ago

@maxirmx Yeah, like a bunch of other PRs :) Waiting for the second approval cc @ronaldtse

ni4 commented 3 months ago

@maxirmx Now PR with CI fixes is merged, could you please rebase this? Or I can do that as well.

ni4 commented 3 months ago

@maxirmx ....and one more thing - macos-11 runner deprecation at the end of June, with scheduled failures at Jun, 24 :) https://github.com/rnpgp/rnp/pull/2239/commits/fb22831a65e0cef3ddaa37b53ea2151054387ea1

maxirmx commented 3 months ago

@maxirmx ....and one more thing - macos-11 runner deprecation at the end of June, with scheduled failures at Jun, 24 :) fb22831

Does it mean that it shall not ve merged ?