search

rnpgp / rnp

RNP: high performance C++ OpenPGP library used by Mozilla Thunderbird
https://www.rnpgp.org
Other
201 stars 55 forks source link

Refactor pgp_key_material_t to C++. #2250

Closed ni4 closed 3 months ago

ni4 commented 4 months ago

To avoid anonymous opaque unions and bring more flexibility to the codebase.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 83.64706% with 139 lines in your changes missing coverage. Please review.

Project coverage is 83.75%. Comparing base (e3662a7) to head (878e89b). Report is 10 commits behind head on main.

Files Patch % Lines
src/lib/key_material.cpp 81.40% 93 Missing :warning:
src/lib/rnp.cpp 50.00% 16 Missing :warning:
src/librekey/key_store_g10.cpp 86.66% 12 Missing :warning:
src/librepgp/stream-dump.cpp 94.04% 5 Missing :warning:
src/lib/key_material.hpp 84.61% 4 Missing :warning:
src/lib/pgp-key.cpp 83.33% 4 Missing :warning:
src/lib/crypto.cpp 60.00% 2 Missing :warning:
src/librepgp/stream-key.cpp 88.23% 2 Missing :warning:
src/lib/crypto/signatures.cpp 94.73% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2250 +/- ## ========================================== + Coverage 83.58% 83.75% +0.17% ========================================== Files 107 113 +6 Lines 23163 23246 +83 ========================================== + Hits 19360 19470 +110 + Misses 3803 3776 -27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ni4 commented 4 months ago

@falko-strenzke @TJ-91 Possibly you'd want to take a look at this PR as it changes some of the PQC code.

ni4 commented 3 months ago

@ronaldtse @desvxx Ping for review.