search

rnpgp / rnp

RNP: high performance C++ OpenPGP library used by Mozilla Thunderbird
https://www.rnpgp.org
Other
201 stars 55 forks source link

Refactor pgp_key_t methods for noexcept and fix few coverity issues. #2265

Closed ni4 closed 2 months ago

ni4 commented 2 months ago

...also return key material from pgp_key_t by pointer instead of references.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.00%. Comparing base (08e277d) to head (3c4cc4b). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/rnp.cpp 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2265 +/- ## ========================================== + Coverage 83.90% 84.00% +0.09% ========================================== Files 113 113 Lines 23092 23066 -26 ========================================== + Hits 19376 19377 +1 + Misses 3716 3689 -27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ni4 commented 2 months ago

Having approvals and green CI - let's merge it. Thanks all!