Add option for json output for the packet dumper

rnpgp / rnp

RNP: high performance C++ OpenPGP library used by Mozilla Thunderbird

https://www.rnpgp.org

Other

201 stars 55 forks source link

Add option for json output for the packet dumper #668

Closed ni4 closed 5 years ago

ni4 commented 6 years ago

Description

It would be handy to have packet dumper which outputs json object, and corresponding tests.

dewyatt commented 6 years ago

Just adding a note but the main reason I wanted this was so that it would be easier to test our generated packets, like checking the s2k iteration count in https://github.com/riboseinc/rnp/pull/728#issuecomment-418144160 and similar things. It's one thing to test some function input, but we really need to be testing generated packets.

ni4 commented 6 years ago

Agree, @dewyatt .

ni4 commented 5 years ago

Was fixed in PR #837 so closing this.