Build instructions don't work on Ubuntu 18.04.3 LTS

ronaldtse commented 4 years ago

Description

On Ubuntu 18.04.3 LTS, I followed the steps for Debian build from the README, and got this message during CMake. The problem is the Botan version is 2.4.0 but RNP 0.12 requires 2.5.0.

This relates to #980.

Steps to Reproduce

git clone https://github.com/rnpgp/rnp -b v0.12.0
mkdir rnpbuild; cd rnpbuild
cmake -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_SHARED_LIBS=on -DBUILD_TESTING=off ../rnp/

Expected Behavior

RNP compiles.

Actual Behavior

HEAD is now at 586caec6 Release 0.12.0
root@aa16642f9338:/rnp# cd ../rnpbuild/
root@aa16642f9338:/rnpbuild# cmake -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_SHARED_LIBS=on -DBUILD_TESTING=off ../rnp/
-- RNP_VERSION: 0.12.0
-- RNP_VERSION_NCOMMITS: 0
-- RNP_VERSION_GIT_REV: 586caec
-- RNP_VERSION_IS_DIRTY: FALSE
-- RNP_VERSION_COMMIT_TIMESTAMP: 0
-- RNP_VERSION_SUFFIX: 
-- RNP_VERSION_FULL: 0.12.0
CMake Error at /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find Botan2: Found unsuitable version "2.4.0", but required is at
  least "2.5.0" (found /usr/lib/libbotan-2.so)
Call Stack (most recent call first):
  /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:376 (_FPHSA_FAILURE_MESSAGE)
  cmake/Modules/FindBotan2.cmake:91 (find_package_handle_standard_args)
  src/lib/CMakeLists.txt:33 (find_package)

rrrooommmaaa commented 4 years ago

max version packaged for Ubuntu 18.04 is 2.4.0, for 18.10 -- 2.6.0, for 19 -- 2.9.0 So will have to build and install Botan2 manually (as I did for snap package), right? https://github.com/randombit/botan/wiki/Distros

ronaldtse commented 4 years ago

@rrrooommmaaa yes you're right. Could you help with this? Thanks!

rnpgp / rnp