Update s2k iteration dumping and add tests for s2k iteration count check.

rnpgp / rnp

RNP: high performance C++ OpenPGP library used by Mozilla Thunderbird

https://www.rnpgp.org

Other

194 stars 55 forks source link

Update s2k iteration dumping and add tests for s2k iteration count check. #999

Closed ni4 closed 4 years ago

ni4 commented 4 years ago

Description

We need to be sure that correct iteration count is actually used when user calls rnp_op_encrypt_add_password(). Check could be done via packet dumping and checking of output.

Also currently output is a bit misleading (see https://github.com/rnpgp/rnp/issues/982#issuecomment-562953955) so it should be corrected as well as rnp_op_encrypt_ad_password() function's documentation.

For the full discussion see #982

ni4 commented 4 years ago

@rrrooommmaaa also there is a related issue #531 - while s2k parameters selection is done for rnpkeys it is not supported in rnp CLI.