search

rnpgp / ruby-rnp

Ruby bindings for librnp
https://www.rnpgp.org
MIT License
7 stars 3 forks source link

Exposing AEAD? #13

Closed ronaldtse closed 5 years ago

ronaldtse commented 6 years ago

AEAD is accessible via the command line but doesn't seem allowed here.

dewyatt commented 5 years ago

I think I can get this added since https://github.com/riboseinc/rnp/commit/8d0eccd32ea25f6a1183226d0cd113a3a1b78596.

dewyatt commented 5 years ago

Revisiting this, it's easy to add but I can't add any useful tests until I have a way to verify AEAD is used (via https://github.com/riboseinc/rnp/issues/668 or otherwise).

When I tested this out today, I made a small mistake and that caused everything to work perfectly except it wasn't actually using AEAD at all. So I would rather wait on this until we have a way to write useful tests.

ni4 commented 5 years ago

@dewyatt I started some work on JSON packet dumping and adding it to FFI. It is needed for migration of rnp CLI to FFI. rnp_key_get_someting functions not always usable since return strings, while rnpkeys require some raw data to print, like algo numbers and so on.

dewyatt commented 5 years ago

Thanks to @ni4 this was taken care of in 5b92098.