search

rnpgp / ruby-rnp

Ruby bindings for librnp
https://www.rnpgp.org
MIT License
7 stars 3 forks source link

Relax Bundler constraint (allow 2.x) #36

Closed skalee closed 5 years ago

skalee commented 5 years ago

Bundler 2.0 has been released this month. This change relaxes the development dependency constraint in order to allow this version. A new constraint which forbids 3.x has been introduced instead.

Keeping the constraint unchanged, apart from being potentially inconvenient for developers, could lead to a problem, which has been observed in other gems developed by Ribose Inc. — some Rubies in Travis CI come with Bundler preinstalled, causing builds to fail if it is Bundler 2. An alternative solution is to enforce a specific Bundler version in Travis (simply installing it is not enough). However, allowing Bundler 2 is simpler and cleaner in case of this gem.

This gem does not rely on Bundler except for managing development gems, therefore no regression should happen.

codecov[bot] commented 5 years ago

Codecov Report

Merging #36 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files          23       23           
  Lines        1754     1754           
=======================================
  Hits         1729     1729           
  Misses         25       25

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5870b93...f8f0c0d. Read the comment docs.